Skip to content

Conversation

@ccharly
Copy link
Contributor

@ccharly ccharly commented Jan 12, 2026

Replace KeyringVersion support to a feature-based variant.

This will allow to re-use a proper versioning of the keyring with the introduction of keyring capabilities.


Note

Replaces version-based compatibility with explicit feature flags and updates legacy request handling across packages.

  • Introduces KeyringInternalFeature (adds UseOrigin) and KeyringInternalFeatures; removes KeyringVersion
  • Replaces platform mapping with PLATFORM_VERSION_TO_KEYRING_FEATURES and getKeyringFeaturesFromPlatform
  • Renames v1 request types/methods to Legacy* (e.g., toLegacyKeyringRequest, LegacyKeyringRequest{,Struct}, LegacyKeyringResponse{,Struct}); updates exports to compatibility/legacy
  • Renames client API submitRequestV1 to submitLegacyRequest and uses SubmitRequestResponseV1Struct
  • Updates SnapKeyring to select submitRequest vs submitLegacyRequest based on UseOrigin; removes version-based submission path
  • Updates tests and CHANGELOGs to reflect new feature-flag model and API renames

Written by Cursor Bugbot for commit 713d8c3. This will update automatically on new commits. Configure here.

@ccharly ccharly requested a review from a team as a code owner January 12, 2026 13:40
@ccharly ccharly changed the title feat: add KeyringInternalFeature{,s} support feat: add KeyringInternalFeature{,s} support Jan 12, 2026
hmalik88
hmalik88 previously approved these changes Jan 13, 2026
@ccharly ccharly changed the title feat: add KeyringInternalFeature{,s} support feat!: rename KeyringVersion to KeyringInternalFeature{,s} Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants