This repository was archived by the owner on Aug 21, 2025. It is now read-only.
fix: retry mechanism #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
aganglada
approved these changes
Jul 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current retry mechanism on the Esplora client using gloo_timers was failing to execute in SES environment such as MetaMask Snaps where all the objects created are immutable by default (
writable: false). Because gloo_timers updates thecntvalue outside of the main process, the execution crashed without being caught by the try/catch clause, causing the app to crash no matter the error handling mechanism.This PR removes usage of gloo_timers and implements an in-house retry mechanism. It also adds the possiblity to remove the retry mechanism by setting
max_retriesto 0. Allowing for the retry mechanism to be implemented on the JS side.