feat: captureException with claims messenger #7553
Merged
+305
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwin-kyaw
force-pushed
the
feat/claims-sentry
branch
from
b693672 to
54b22a1
Compare
lwin-kyaw
force-pushed
the
feat/claims-sentry
branch
from
54b22a1 to
e69ede4
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
lwin-kyaw
force-pushed
the
feat/claims-sentry
branch
from
7bc2d97 to
411a9d7
Compare
chaitanyapotti
approved these changes
Jan 6, 2026
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR uses
captureExceptionfunction from the base-messenger to capture the claims errors and report to sentry (from the extension).References
Checklist
Note
Add Sentry-backed error reporting and robust HTTP error handling to claims service
fetchClaimsConfigurations,getClaims,getClaimById, andgenerateMessageForClaimSignaturein try/catch; on failures callmessenger.captureException(createSentryError(...))and rethrow user-facing errors.utils.getErrorFromResponseto normalize non-OK HTTP responses (JSON/text/unknown) andcreateSentryErrorto attach original causes; add comprehensive unit tests for both utilities.captureExceptionvia mocked messenger, assert it’s called on failures, and verify error messages (including status codes); add specific tests for rejected fetch and 500 responses.captureException; update CHANGELOG with new behavior.Written by Cursor Bugbot for commit cd6eae6. This will update automatically on new commits. Configure here.