generated from MetaMask/metamask-module-template
-
Notifications
You must be signed in to change notification settings - Fork 5
feat(ocap-kernel): add resource limits for remote communications #714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sirtimid
wants to merge
8
commits into
main
Choose a base branch
from
sirtimid/remote-comms-resource-limits
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a40d3eb to
96f26e2
Compare
- Add connection limit (default 100 concurrent connections) - Add message size limit (default 1MB per message) - Add stale peer cleanup (removes data for peers disconnected >1 hour) - Make all limits configurable via RemoteCommsOptions - Add ResourceLimitError for limit violations - Add comprehensive tests for all resource limits This prevents memory exhaustion and manages system resources by: - Rejecting new connections when limit is reached - Rejecting messages exceeding size limit - Periodically cleaning up stale peer data
b6c23e0 to
25e81ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #660
This prevents memory exhaustion and manages system resources by:
Note
Enforces connection and message-size limits with stale peer cleanup, adds ResourceLimitError, and updates reconnection and stream-closing logic.
remotes):100) on outbound and inbound paths with race-condition safeguards.1MB) via pre-send validation.lastConnectionTime.RemoteCommsOptions(maxConcurrentConnections,maxMessageSizeBytes,cleanupIntervalMs,stalePeerTimeoutMs).closeChannelinConnectionFactoryto close/abort underlying stream; addregisterChannel,checkConnectionLimit,validateMessageSizehelpers.ResourceLimitError: CodeRESOURCE_LIMIT_ERROR, marshaling schema/validation and unmarshal support; exported and mapped inerrorClasseswith tests.Written by Cursor Bugbot for commit 8e04986. This will update automatically on new commits. Configure here.