Skip to content

Conversation

@FUDCo
Copy link
Contributor

@FUDCo FUDCo commented Dec 19, 2025

Since we stopped handling location hints as a parameter to sendRemoteMessage, the message queue element was reduced to an object holding a single string property, which is silly. This PR changes it to just a string.


Note

Replaces QueuedMessage objects with raw string messages across the queue and network code, adjusting APIs, logging, and tests.

  • Remotes/Queue:
    • Refactor MessageQueue to store raw string messages (remove QueuedMessage).
    • Update methods: enqueue, dequeue, dequeueAll, messages getter, and replaceAll to use string types.
  • Remotes/Network:
    • Adjust queue handling in flushQueuedMessages to process string messages and update logging/serialization (fromString).
    • Rename receiveMsg to receiveMessage and update call sites.
  • Tests:
    • Update MessageQueue.test.ts and network.test.ts mocks/expectations to use plain strings.

Written by Cursor Bugbot for commit a5ca873. This will update automatically on new commits. Configure here.

@FUDCo FUDCo requested a review from a team as a code owner December 19, 2025 19:34
@FUDCo FUDCo force-pushed the chip/message-queue-cleanup branch from 65eef18 to 52f2d08 Compare December 19, 2025 19:38
Copy link
Contributor

@grypez grypez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FUDCo FUDCo merged commit 6c1f82f into main Dec 19, 2025
26 checks passed
@FUDCo FUDCo deleted the chip/message-queue-cleanup branch December 19, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants