-
Notifications
You must be signed in to change notification settings - Fork 637
chore: Bump @metamask/eslint-config-typescript from 14.0.0 to 15.0.0 #3766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: Bump @metamask/eslint-config-typescript from 14.0.0 to 15.0.0 #3766
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| "@metamask/eslint-config-jest": "^14.0.0", | ||
| "@metamask/eslint-config-nodejs": "^14.0.0", | ||
| "@metamask/eslint-config-typescript": "^14.0.0", | ||
| "@metamask/eslint-config-typescript": "^15.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Unmet peer dependency for eslint-config-typescript upgrade
The @metamask/eslint-config-typescript package is being upgraded to version 15.0.0, which requires @metamask/eslint-config@^15.0.0 as a peer dependency. However, @metamask/eslint-config remains at ^14.0.0. This peer dependency mismatch could cause eslint configuration conflicts or failures since the packages are designed to work together at matching major versions.
Additional Locations (2)
| typescript-eslint: ^8.6.0 | ||
| checksum: 10/cbf0a9e8523292d41140f90630863d034301422f16e6a42e5881c3593e83c07d0394787563d3e88fee02aa22042a9ca974363d3f192374e31bb0729c6ca8734e | ||
| typescript: ">=4.8.4 <6" | ||
| typescript-eslint: ^8.39.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Unmet typescript-eslint peer dependency version requirement
The upgraded @metamask/eslint-config-typescript@15.0.0 requires typescript-eslint: ^8.39.0 as a peer dependency, but the project specifies typescript-eslint: ^8.6.0 which resolves to version 8.24.0. This unmet peer dependency could cause compatibility issues or unexpected linting behavior, as the config package expects a newer version of the TypeScript ESLint tooling.
Additional Locations (1)
Bumps [@metamask/eslint-config-typescript](https://github.com/MetaMask/eslint-config) from 14.0.0 to 15.0.0. - [Release notes](https://github.com/MetaMask/eslint-config/releases) - [Commits](https://github.com/MetaMask/eslint-config/compare/@metamask/eslint-config-typescript@14.0.0...@metamask/eslint-config-typescript@15.0.0) --- updated-dependencies: - dependency-name: "@metamask/eslint-config-typescript" dependency-version: 15.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
f7f55ba to
68a0e7b
Compare
| "@metamask/eslint-config-jest": "^14.0.0", | ||
| "@metamask/eslint-config-nodejs": "^14.0.0", | ||
| "@metamask/eslint-config-typescript": "^14.0.0", | ||
| "@metamask/eslint-config-typescript": "^15.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Peer dependency mismatch with base ESLint config version
The @metamask/eslint-config-typescript upgrade to version 15.0.0 requires @metamask/eslint-config@^15.0.0 as a peer dependency (visible in the yarn.lock changes), but @metamask/eslint-config remains at ^14.0.0. This peer dependency mismatch can cause ESLint configuration incompatibilities and warnings. The base @metamask/eslint-config package also needs to be upgraded to version 15.0.0.
Bumps @metamask/eslint-config-typescript from 14.0.0 to 15.0.0.
Release notes
Sourced from
@metamask/eslint-config-typescript's releases.... (truncated)
Commits
0b8cf6dRelease/15.0.0 (#431)9568eb3fix: Disablejsdoc/check-indentationto fix bullet list formatting (#430)7837174feat: Loosen@typescript-eslint/naming-conventionfor object literal proper...cf93ef1fix: Disableimport-x/no-duplicatesin TypeScript files (#427)f3246f7chore: Disable redudant lint rule (#425)383fbecfeat: Disable@typescript-eslint/no-unnecessary-type-arguments(#426)a0e0bc8feat: Convert all warnings to errors (#424)b243e90chore: Increase minimumtypescript-eslintversion (#423)b116974Allow remaining TypeScript 5.x versions (#422)c70a3ffBREAKING: Updatejsdoc/require-jsdocto require documentation for more thin...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Note
Upgrade @metamask/eslint-config-typescript to 15.0.0 and update yarn.lock, including peer range adjustments.
Written by Cursor Bugbot for commit 68a0e7b. This will update automatically on new commits. Configure here.