Feat/update package #451
Open
Feat/update package #451
+6,444
−8,466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: custom token
feat: import token confirmation popup for spl tokens
ieow
reviewed
Nov 8, 2024
| .reduce((acc: SolanaToken[], current: TokenInfo) => { | ||
| const userToken = this.userTokens.find((token) => token.mintAddress === current.address); | ||
|
|
||
| if (userToken?.balance) { |
Contributor
There was a problem hiding this comment.
if userToken.balance === 0 , we should not add new customToken to the display
else we will see 2 token with same address and balance 0 ?
Contributor
Author
There was a problem hiding this comment.
yes the below line ignores if the user has balance for that token
ieow
approved these changes
Nov 19, 2024
Contributor
ieow
left a comment
ieow
left a comment
There was a problem hiding this comment.
lgtm
can merge after controller rebase is resolved
fix: refresh token and import tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information