Skip to content

Conversation

@jbouder
Copy link
Contributor

@jbouder jbouder commented Nov 12, 2025

Description

  • Use fastapi root_path for prefix.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

@jbouder jbouder added the enhancement New feature or request label Nov 12, 2025
Copilot AI review requested due to automatic review settings November 12, 2025 18:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the API path configuration to use FastAPI's root_path parameter instead of manually prefixing each router. This change simplifies router definitions by removing the need for the API_PREFIX setting at the router level, replacing it with a ROOT_PATH setting applied once at the FastAPI application initialization.

Key changes:

  • Replaced API_PREFIX with ROOT_PATH in application settings
  • Applied root_path parameter when initializing the FastAPI application
  • Simplified all router prefix definitions to use relative paths

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
app/config.py Renamed API_PREFIX setting to ROOT_PATH
app/main.py Added logic to set FastAPI root_path from settings
app/health/router.py Removed settings import and simplified router prefix
app/cases/router.py Removed settings import and simplified router prefix
app/applicants/router.py Simplified router prefix to use relative path
app/admin/router.py Simplified router prefix to use relative path
README.md Updated documentation to reference ROOT_PATH instead of API_PREFIX

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jbouder jbouder merged commit 9403396 into main Nov 12, 2025
7 checks passed
@jbouder jbouder deleted the use-root-path branch November 12, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants