Skip to content

DesignerFileCountToKeep was being ignored and all designer files were… #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PaulKeating1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DesignerFileCountToKeep was being ignored and all designer files were… #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions EFCoreFileManipulator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,24 @@ internal class EFCoreFileManipulator
static readonly Regex MigrationRegex = new Regex(@".*\[Migration\(""(?<MigrationName>.*)""\)\].*(\r\n|\r|\n)", RegexOptions.Compiled);
static readonly Regex DbContextRegex = new Regex(@".*\[DbContext\(typeof\((?<DBContextName>.*)\)\)\].*(\r\n|\r|\n)", RegexOptions.Compiled);
static readonly Regex LineBreakDetection = new Regex(@".*(?<LineBreakStyle>(\r\n|\r|\n))", RegexOptions.Compiled);

private readonly TaskLoggingHelper _taskLoggingHelper;

public EFCoreFileManipulator(TaskLoggingHelper taskLoggingHelper)
{
_taskLoggingHelper = taskLoggingHelper;
}

public void ProcessDirectory(DirectoryInfo directory, string namespaceName)
public void ProcessDirectory(DirectoryInfo directory, string namespaceName, int designerFileCountToKeep)
{
var filesToProcess = new List<(FileInfo MigrationFile, FileInfo DesignerFile)>();
foreach (var file in directory.EnumerateFiles("*.Designer.cs").OrderBy(x => x.Name))
foreach (var file in directory.EnumerateFiles("*.Designer.cs").OrderByDescending(x => x.Name).Skip(designerFileCountToKeep))
{
filesToProcess.Add((new FileInfo(file.FullName.Replace(".Designer.cs", ".cs")), file));
}

filesToProcess.Reverse();

foreach (var (migrationFile, designerFile) in filesToProcess)
{
if (!designerFile.Exists || !migrationFile.Exists)
Expand Down
2 changes: 1 addition & 1 deletion EFCoreRemoveDesignerCompilationTask.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public override bool Execute()
{
var efCoreFileManipulator = new EFCoreFileManipulator(Log);
var directory = new DirectoryInfo(MigrationFilesPath);
efCoreFileManipulator.ProcessDirectory(directory, DBContextNamespace);
efCoreFileManipulator.ProcessDirectory(directory, DBContextNamespace, DesignerFileCountToKeep);

var latestFiles = directory.EnumerateFiles("*.Designer.cs").OrderByDescending(x => x.Name).Take(DesignerFileCountToKeep);
LatestDesignerFiles = latestFiles.Select(x => x.FullName).ToArray();
Expand Down