Skip to content

Conversation

@priyapatel17451
Copy link

Submitted via Learn Editor.

@priyapatel17451 priyapatel17451 marked this pull request as ready for review May 2, 2024 20:33
@priyapatel17451 priyapatel17451 marked this pull request as draft May 2, 2024 20:34
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 8daa405:

✅ Validation status: passed

File Status Preview URL Details
Docs/Overview/product-versions.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@priyapatel17451 priyapatel17451 marked this pull request as ready for review May 2, 2024 20:40
@priyapatel17451 priyapatel17451 marked this pull request as draft May 2, 2024 20:40
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 8256b34:

✅ Validation status: passed

File Status Preview URL Details
Docs/Overview/product-versions.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 5217986:

💡 Validation status: suggestions

File Status Preview URL Details
Docs/Overview/product-versions.md 💡Suggestion Details
Docs/Overview/media/product-versions/image.png ✅Succeeded
Docs/Overview/media/product-versions/image1.png ✅Succeeded
Docs/Overview/media/product-versions/image2.png ✅Succeeded

Docs/Overview/product-versions.md

  • Line 55, Column 2: [Suggestion: column-header-missing - See documentation] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link

@hajya hajya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look. I had a few comments but I wonder if they have to do with how the Learn UI tool works. for example, i am not sure if you can 1) move the image files around in the repo, 2) i am not sure if you can edit Alt-Text for the images.

> |May'20|**4.4**| - See [What's New in PlayReady Version 4.4](what-is-new/what-is-new-4-4.md) | 4.4.6621 | 4.4.6621 | 4.4.6621 | — | — |
> |Oct'21|**4.5**| - See [What's New in PlayReady Version 4.5](what-is-new/what-is-new-4-5.md) | 4.5.7218 | 4.5.7218 | 4.5.7220 | — | — |
> |Dec'22|**4.6**| - See [What's New in PlayReady Version 4.6](what-is-new/what-is-new-4-6.md) | 4.6.7668 | 4.6.7604 | 4.6.7673 | — | — |
> |May'22|**4.6**|Required Release|4.6.7674 |4.6.7674|— |— |— |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the 'dash' needs to be '—' ? based on the prior rows.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other images are all under the images/ folder under the root. I am not sure if that is just standard practice or required, but we should probably do the same? (../images/pk-server-compatibility.png)

![User's image](media/product-versions/image2.png)

|   |   |
|||
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intentional removal?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed - unintentional (I think Learn UI)

The following table lists the compatibility between the various PlayReady Device Porting Kit and PlayReady Server SDK versions:

![Porting Kit and Server Compatibility](../images/pk-server-compatibility.png)
![User's image](media/product-versions/image2.png)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the alt-text should probably still be: [Porting Kit and Server Compatibility]

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 5576dd4:

💡 Validation status: suggestions

File Status Preview URL Details
Docs/Overview/product-versions.md 💡Suggestion Details
Docs/Overview/media/product-versions/image.png ✅Succeeded
Docs/Overview/media/product-versions/image1.png ✅Succeeded
Docs/Overview/media/product-versions/image2.png ✅Succeeded

Docs/Overview/product-versions.md

  • Line 55, Column 2: [Suggestion: column-header-missing - See documentation] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit cec4952:

💡 Validation status: suggestions

File Status Preview URL Details
Docs/Overview/product-versions.md 💡Suggestion Details
Docs/Overview/media/product-versions/image.png ✅Succeeded
Docs/Overview/media/product-versions/image1.png ✅Succeeded
Docs/Overview/media/product-versions/image2.png ✅Succeeded

Docs/Overview/product-versions.md

  • Line 55, Column 2: [Suggestion: column-header-missing - See documentation] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 405017a:

✅ Validation status: passed

File Status Preview URL Details
Docs/Overview/media/product-versions/image.png ✅Succeeded
Docs/Overview/media/product-versions/image1.png ✅Succeeded
Docs/Overview/media/product-versions/image2.png ✅Succeeded
Docs/Overview/product-versions.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit d40e5d5:

✅ Validation status: passed

File Status Preview URL Details
Docs/Overview/media/product-versions/image.png ✅Succeeded
Docs/Overview/media/product-versions/image1.png ✅Succeeded
Docs/Overview/media/product-versions/image2.png ✅Succeeded
Docs/Overview/product-versions.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 94c0336:

✅ Validation status: passed

File Status Preview URL Details
Docs/Overview/media/product-versions/image.png ✅Succeeded
Docs/Overview/media/product-versions/image1.png ✅Succeeded
Docs/Overview/media/product-versions/image2.png ✅Succeeded
Docs/Overview/product-versions.md ✅Succeeded
Docs/PlayReady/images/pk-server-compatibility.png ✅Succeeded n/a (file deleted or renamed)

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 3001a59:

✅ Validation status: passed

File Status Preview URL Details
Docs/Overview/media/product-versions/image2.png ✅Succeeded
Docs/Overview/product-versions.md ✅Succeeded
Docs/PlayReady/images/pk-server-compatibility.png ✅Succeeded n/a (file deleted or renamed)

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 44300e7:

✅ Validation status: passed

File Status Preview URL Details
Docs/Overview/media/product-versions/image2.png ✅Succeeded
Docs/Overview/product-versions.md ✅Succeeded
Docs/PlayReady/images/pk-server-compatibility.png ✅Succeeded n/a (file deleted or renamed)

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit bba0d7b:

✅ Validation status: passed

File Status Preview URL Details
Docs/Overview/media/product-versions/image2.png ✅Succeeded
Docs/Overview/product-versions.md ✅Succeeded
Docs/PlayReady/images/pk-server-compatibility.png ✅Succeeded n/a (file deleted or renamed)

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 0ba190d:

✅ Validation status: passed

File Status Preview URL Details
Docs/Overview/media/product-versions/image2.png ✅Succeeded
Docs/Overview/product-versions.md ✅Succeeded
Docs/PlayReady/images/pk-server-compatibility.png ✅Succeeded n/a (file deleted or renamed)

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 60029e7:

✅ Validation status: passed

File Status Preview URL Details
Docs/Overview/media/product-versions/image2.png ✅Succeeded
Docs/Overview/product-versions.md ✅Succeeded
Docs/PlayReady/images/pk-server-compatibility.png ✅Succeeded n/a (file deleted or renamed)

For more details, please refer to the build report.

For any questions, please:

@priyapatel17451 priyapatel17451 marked this pull request as ready for review October 30, 2024 17:23
@priyapatel17451
Copy link
Author

#sign-off

Reviewed by Josh Tucker and myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants