-
Notifications
You must be signed in to change notification settings - Fork 1
Custom row action visibility #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug where custom row actions were not visible in grids when no standard actions (copy, update, view, delete) were enabled, and includes refactoring to support multiple UI frameworks beyond Blazor.
Key changes:
- Fixed the actions menu visibility calculation to include custom row actions
- Added
INotifyPropertyChangedimplementation to the baseViewModelclass - Introduced new strongly-typed methods (
Table,SectionList,ReorderableSectionList) to replace the genericFormFieldmethod for list fields - Added new
FormFieldTypeenum values with corresponding documentation
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Mimeo.DynamicUI/ViewModel.cs | Added INotifyPropertyChanged support and new list field helper methods; deprecated old FormField overloads |
| Mimeo.DynamicUI/TextFieldDefinition.cs | Made Items property auto-detect Combobox type for backwards compatibility |
| Mimeo.DynamicUI/ListFieldDefinition.cs | Added new constructor with FormFieldType parameter and deprecated old PresentationMode property |
| Mimeo.DynamicUI/FormFieldType.cs | Added Combobox, Table, SectionList, ReorderableSectionList enum values with documentation |
| Mimeo.DynamicUI/FormFieldDefinition.cs | Added DescriptionLanguageKey property |
| Mimeo.DynamicUI/Data/OData/ODataExpressionGenerator.cs | Extended filter operator support to new list field types |
| Mimeo.DynamicUI.Demo/Mimeo.DynamicUI.Demo.Shared/ViewModels/TestViewModel.cs | Updated demo to use new list field methods and removed redundant INotifyPropertyChanged implementations |
| Mimeo.DynamicUI.Blazor/Forms/ODataGrid.razor.cs | Fixed actions menu visibility to include custom row actions |
| Mimeo.DynamicUI.Blazor/FormFields/ListField.razor | Updated to check FormFieldType instead of deprecated PresentationMode |
| Mimeo.DynamicUI.Blazor/FormFields/DynamicField.cs | Added mappings for new form field types |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.