Skip to content

Conversation

@evandixon
Copy link
Collaborator

@evandixon evandixon commented Oct 21, 2025

  • Fix custom row actions not being shown in ODataGrid if no other non-custom actions are shown
  • Misc refactors to make it easier to add support for UI frameworks other than Blazor

@evandixon evandixon requested a review from Copilot October 21, 2025 20:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where custom row actions were not visible in grids when no standard actions (copy, update, view, delete) were enabled, and includes refactoring to support multiple UI frameworks beyond Blazor.

Key changes:

  • Fixed the actions menu visibility calculation to include custom row actions
  • Added INotifyPropertyChanged implementation to the base ViewModel class
  • Introduced new strongly-typed methods (Table, SectionList, ReorderableSectionList) to replace the generic FormField method for list fields
  • Added new FormFieldType enum values with corresponding documentation

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Mimeo.DynamicUI/ViewModel.cs Added INotifyPropertyChanged support and new list field helper methods; deprecated old FormField overloads
Mimeo.DynamicUI/TextFieldDefinition.cs Made Items property auto-detect Combobox type for backwards compatibility
Mimeo.DynamicUI/ListFieldDefinition.cs Added new constructor with FormFieldType parameter and deprecated old PresentationMode property
Mimeo.DynamicUI/FormFieldType.cs Added Combobox, Table, SectionList, ReorderableSectionList enum values with documentation
Mimeo.DynamicUI/FormFieldDefinition.cs Added DescriptionLanguageKey property
Mimeo.DynamicUI/Data/OData/ODataExpressionGenerator.cs Extended filter operator support to new list field types
Mimeo.DynamicUI.Demo/Mimeo.DynamicUI.Demo.Shared/ViewModels/TestViewModel.cs Updated demo to use new list field methods and removed redundant INotifyPropertyChanged implementations
Mimeo.DynamicUI.Blazor/Forms/ODataGrid.razor.cs Fixed actions menu visibility to include custom row actions
Mimeo.DynamicUI.Blazor/FormFields/ListField.razor Updated to check FormFieldType instead of deprecated PresentationMode
Mimeo.DynamicUI.Blazor/FormFields/DynamicField.cs Added mappings for new form field types

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@evandixon evandixon requested a review from Copilot October 21, 2025 20:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@evandixon evandixon merged commit 9ccdb1d into main Oct 22, 2025
6 checks passed
@evandixon evandixon deleted the custom-row-action-visibility branch October 22, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants