build: use version catalog & convention plugins #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattSturgeon
force-pushed
the
convention-plugins
branch
from
309de2e to
bf88a7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes a step towards using version catalogs and convention plugins, to centralise plugin version definitions and migrate away from
allprojects {}andsubprojects {}DSL.Using a version catalog for plugin dependencies allows
buildSrc's buildscript to reference the same versions. It also allows for typesafe access to dependencies.So far, version catalogs are only used for plugins, other dependencies are still managed through
gradle.properties. If we switch to a multi-version build, where different MC versions have different mod dependency versions, this will probably remain the simplest approach.There is still some
allprojects {}andsubprojects {}usage. So far I've only migrated the modpublisher config.