Split HW traits to support different configurations #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes writing the drivers a little annoying, as they have to specify that
HW::ErrorimplementsFrom<X::Error>for all the relevant hardware typesX. But, this nuisance is limited to the driver implementations, and doesn't spill over to users of the library.To keep the boilerplate to a minimum, the type definitions put minimal constraints on their generic types (e.g.
Epd2In9expects aHWandSTATEof any type). Each each trait implementation then request just the minimal set of constraints it cares about.For example, the
Resetimplementation just requires the hardware constraintsHW: ResetHw + DelayHw + ErrorHwandHW::Error: From<<HW::Reset as embedded_hal::digital::ErrorType>::Error>.To support both displays with different "busy" pin states, and different wiring configurations of the existing displays, the
BusyHwtrait now also requires abusy_when()function.