Only compile WebKit dependent files on platforms with support #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds platform compatibility support by wrapping WebKit-dependent code in #if canImport(WebKit) compiler directives. This ensures the ConnectAccountsUI module compiles on platforms that don't have WebKit support (such as Linux or watchOS).
- Wraps
ConnectWebHandler.swiftandGenerateAPIKeyView.swiftin WebKit availability guards - Keeps public API types (
APIKeyValidator,APIKeyCredentials) available on all platforms for API consistency - Includes minor code cleanup (removal of
self.prefix and trailing newline)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Sources/ConnectAccountsUI/Internal/ConnectWebHandler.swift | Wrapped entire file in #if canImport(WebKit) guard; removed unnecessary self. prefix in init method |
| Sources/ConnectAccountsUI/Internal/APIKeyValidator.swift | Removed trailing newline (whitespace cleanup) |
| Sources/ConnectAccountsUI/GenerateAPIKeyView.swift | Wrapped entire file in #if canImport(WebKit) guard to prevent compilation on non-WebKit platforms |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces platform-specific code handling by wrapping certain files in
#if canImport(WebKit)directives, ensuring that the code is only compiled when theWebKitmodule is available - some platforms doesn't have the WebKit framework.