Skip to content

Conversation

@arkanoider
Copy link
Collaborator

Hi @grunch @bilthon !

Some improvements on config files and db file:

  • Switched MOSTRO_CONFIG variable from lazy_static to OnceLock which is included in std lib now. Maybe you could have to update to latest Rust. Next time I will try to use OnceCell to remove also variable of RATE_EVENT_LIST from lazy static so we can remove the not maintained crate.
  • I changed settings.toml to settings.tpl.toml in .init_db.sh for compatibility and made config path the one in which db file is searched at startup.

Now what is happening is that user will launch in root folder the db init then launches mostro that creates path for settings and db file, then will print out to copy both file in the folder.
Maybe we could improve in some way that file copy and db creation are automated, but I don't if it's a good idea...

Waiting for advice... ;)

Copy link
Member

@grunch grunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥳

@grunch grunch merged commit a6d6635 into MostroP2P:main Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants