Skip to content

Syntax modernization: Convert var to let/const for better maintainability #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HendrikCromboom wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Syntax modernization: Convert var to let/const for better maintainability #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/hello.chromeapp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ if (typeof chrome === 'object' && typeof chrome.identity === 'object' && chrome.
};

// Swap the storage method
var _cache = {};
let _cache = {};
chrome.storage.local.get('hello', function(r) {
// Update the cache
_cache = r.hello || {};
Expand Down Expand Up @@ -70,7 +70,7 @@ if (typeof chrome === 'object' && typeof chrome.identity === 'object' && chrome.
function _open(url, interactive) {

// Launch
var ref = {
const ref = {
closed: false
};

Expand All @@ -87,11 +87,11 @@ if (typeof chrome === 'object' && typeof chrome.identity === 'object' && chrome.
}

// Split appart the URL
var a = hello.utils.url(responseUrl);
const a = hello.utils.url(responseUrl);

// The location can be augmented in to a location object like so...
// We dont have window operations on the popup so lets create some
var _popup = {
const _popup = {
location: {

// Change the location of the popup
Expand Down
Loading