fix: resolve issues in license and package versions #13
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request attempts to update dependency version constraints and change the project license, but contains several critical issues that need to be addressed before merging.
Key Changes:
- Updated dependency version specifiers from exact pins (
==) to compatible release (~=) to allow minor/patch updates - Changed project license from GNU AGPL v3 to MIT License
- Modified both
pyproject.tomlandrequirements.txtdependency specifications
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pyproject.toml | Updated 10 dependency version constraints from == to ~=, allowing compatible minor/patch version updates |
| requirements.txt | Updated 14 dependency version constraints from == to ~=; includes additional dependencies not in pyproject.toml |
| LICENSE | Complete license change from GNU AGPL v3 (661 lines) to MIT License (21 lines) with incorrect copyright attribution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
pyproject.toml:17
- The license classifier still references AGPL v3, but the LICENSE file has been changed to MIT. This classifier must be updated to 'License :: OSI Approved :: MIT License' to match the new license.
"License :: OSI Approved :: GNU Affero General Public License v3",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pyproject.toml
Outdated
| "lagom>=2.6.0", | ||
| "pydantic>=2.9.2", | ||
| "fastapi>=0.100.0", | ||
| "python-socketio>=5.12.1", | ||
| "python-socketio[client]>=5.12.1", | ||
| "uvicorn[standard]>=0.30.6", | ||
| "uvicorn-worker>=0.2.0", | ||
| "python-multipart>=0.0.10", | ||
| "httpx~=0.27.2", |
There was a problem hiding this comment.
Django has been removed from dependencies but the project has Django integration code in src/chromatrace/django.py that imports from django.http. Django must be added back to the dependencies list.
* Updated `httpx` version constraint in `pyproject.toml` to `>=0.27.2`. * Organized dependencies in `requirements.txt` for clarity. * Removed redundant configuration from `setup.cfg`. * Added `ruff` and `mypy` configurations for improved linting and type checking.
* Removed unused arguments in `SysLogFormatter`. * Organized import statements across multiple files for consistency. * Ensured all files end with a newline for better compatibility.
* Changed the value of `asyncio_default_fixture_loop_scope` in `pytest.ini` from a string to a bareword for consistency with pytest configuration.
This pull request updates the dependency version constraints in the
pyproject.tomlfile to allow for more flexibility in minor and patch version upgrades. Instead of requiring exact versions for each dependency, the constraints now use the~=operator, which permits updates that do not change the major version.Dependency version constraint changes:
dependencieslist by switching from exact versions (==) to compatible release (~=) specifiers, allowing minor and patch updates while maintaining major version stability. (pyproject.toml)