Mul 1865 new logic and interface for eos tx #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change file name from `EOS` to `eos` move struct EosTransactionAction to new file move struct EosTransactionTransferAction to new file
PashaKlybik
force-pushed
the
MUL-1865-New-logic-and-interface-for-EOS-Tx
branch
5 times, most recently
from
408c917 to
c64af94
Compare
Create EOS transfer transaction builder
PashaKlybik
force-pushed
the
MUL-1865-New-logic-and-interface-for-EOS-Tx
branch
from
c64af94 to
728d8cd
Compare
Enmk
suggested changes
Apr 29, 2019
Contributor
Enmk
left a comment
Enmk
left a comment
There was a problem hiding this comment.
Some modifications required
| const std::array<uint8_t, 32> EOS_ZERO_SHA256 = {0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, | ||
| 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}; | ||
|
|
||
| void putVariableUInt(EosBinaryStream* stream, uint64_t value) |
Contributor
There was a problem hiding this comment.
Please update signature:
WriteToStream(uint64_t value, EosBinaryStream* stream)
| { | ||
| do | ||
| { | ||
| uint8_t input = static_cast<uint8_t>(value & 0x7f); |
| 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}; | ||
|
|
||
| void putVariableUInt(EosBinaryStream* stream, uint64_t value) | ||
| { |
Contributor
There was a problem hiding this comment.
Please put a link to reference documentation here
| static const std::unordered_map<size_t, BuilderFactoryFunction> BUILDERS = | ||
| { | ||
| { | ||
| EOS_TRANSACTION_BUILDER_UPDATEAUTH, |
Contributor
There was a problem hiding this comment.
IIRC, we now have an additional overload that takes string as builder name, please add it here.
| { | ||
| THROW_EXCEPTION2(ERROR_FEATURE_NOT_IMPLEMENTED_YET, __FUNCTION__); | ||
| return m_data_string; | ||
| //THROW_EXCEPTION2(ERROR_FEATURE_NOT_IMPLEMENTED_YET, __FUNCTION__); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.