-
Notifications
You must be signed in to change notification settings - Fork 1
Create LICENSE #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Create LICENSE #40
Conversation
frafra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The
LICENSEfile is not in thepythonfolder, so it will not be copied to the projects generated with the Python template, but it would only signal that this repository has a MIT license - The MIT licence is incompatible with the metadata in both, as they are using GPLv3:
license = "GPL-3.0+" python-template/pyproject.toml
Line 15 in e07b9cf
license = {text = "GPL-3.0+"}
- Missing
license-filesfield inpyproject.toml: https://packaging.python.org/en/latest/specifications/pyproject-toml/#license-files
I would not change the licence to the python template right away, since that would automatically change the licence of all the projects that have been generated with this template, which is a major change.
|
What about adding a question about license, so that it's compatible for older projects and opt in for new/updating ones? Could be boolean (do you want to include a default FOSS license?) |
|
I think we should have the GPLv3+ as file for all projects. That is what the issue is about. |
|
Okay, I added the |
frafra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid changing the main pyproject.toml, or add a LICENSE file there as well :)
| # See https://www.python.org/dev/peps/pep-0621/ | ||
| dependencies = [] | ||
| description = "" | ||
| licence-files = ["LICENSE"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No license file in the root folder of the repository. You can drop this line.
Add a LICENCE file with the MIT licence