Skip to content

Handling unknown extensions for schedules #11375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
GaryMarksBigladder wants to merge 3 commits into
base: develop
Choose a base branch
from
+8,889 −13
Draft

Handling unknown extensions for schedules #11375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b9330a
Handling unknown extensions for schedules
GaryMarksBigladder Dec 15, 2025
8ee040b
Fixing formatting
GaryMarksBigladder Dec 16, 2025
109769c
Fixing warning
GaryMarksBigladder Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 85 additions & 13 deletions src/EnergyPlus/ScheduleManager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,14 +612,50 @@ namespace Sched {
s_sched->UniqueProcessedExternalFiles.emplace(state.files.TempFullFilePath.filePath, std::move(schedule_data));
schedule_file_shading_result = it.first;
} else {
ShowSevereError(state,
fmt::format(R"({}: {}="{}", {}="{}" has an unknown file extension and cannot be read by this program.)",
routineName,
CurrentModuleObject,
Alphas(1),
cAlphaFields(3),
Alphas(3)));
ShowFatalError(state, "Program terminates due to previous condition.");
// Unknown extension, try to parse csv
bool isCSV = false;
bool isJSON = false;
try {
auto const schedule_data = FileSystem::readFile(state.files.TempFullFilePath.filePath);
CsvParser csvParser;
skiprowCount = 1; // make sure to parse header row only for Schedule:File:Shading
auto it = s_sched->UniqueProcessedExternalFiles.emplace(state.files.TempFullFilePath.filePath,
csvParser.decode(schedule_data, ColumnSep, skiprowCount));
if (!csvParser.hasErrors()) {
isCSV = true;
ShowWarningMessage(state,
fmt::format("Extension of file {} is unrecogonized, but parsed as CSV successfully",
state.files.TempFullFilePath.filePath));
schedule_file_shading_result = it.first;
}
} catch (...) {
// We're testing to see if this is a csv, if any exception exists, then throw the standard error about an unknown
// extension
isCSV = false;
}
try {
auto schedule_data = FileSystem::readJSON(state.files.TempFullFilePath.filePath);
auto it = // (AUTO_OK_ITER)
s_sched->UniqueProcessedExternalFiles.emplace(state.files.TempFullFilePath.filePath, std::move(schedule_data));
schedule_file_shading_result = it.first;
ShowWarningMessage(state,
fmt::format("Extension of file {} is unrecogonized, but parsed as JSON successfully",
state.files.TempFullFilePath.filePath));
isJSON = true;
} catch (...) {
// We're testing to see if this is json, if any exception exists, then throw the standard error about an unknown extension
isJSON = false;
}
if (!isCSV && !isJSON) {
ShowSevereError(state,
fmt::format(R"({}: {}="{}", {}="{}" has an unknown file extension and cannot be read by this program.)",
routineName,
CurrentModuleObject,
Alphas(1),
cAlphaFields(3),
Alphas(3)));
ShowFatalError(state, "Program terminates due to previous condition.");
}
}
}

Expand Down Expand Up @@ -1642,11 +1678,47 @@ namespace Sched {
FileSystem::readJSON(state.files.TempFullFilePath.filePath));
result = it.first;
} else {
ShowSevereCustom(
state,
eoh,
format("{} = {} has an unknown file extension and cannot be read by this program.", cAlphaFields(3), Alphas(3)));
ShowFatalError(state, "Program terminates due to previous condition.");
bool isCSV = false;
bool isJSON = false;
try {
auto const schedule_data = FileSystem::readFile(state.files.TempFullFilePath.filePath);
CsvParser csvParser;
auto it = s_sched->UniqueProcessedExternalFiles.emplace(state.files.TempFullFilePath.filePath,
csvParser.decode(schedule_data, ColumnSep, skiprowCount));
if (!csvParser.hasErrors()) {
result = it.first;
isCSV = true;
ShowWarningMessage(state,
fmt::format("Extension of file {} is unrecogonized, but parsed as CSV successfully",
state.files.TempFullFilePath.filePath));
}
} catch (...) {
// We're testing to see if this is a csv, if any exception exists, then throw the standard error about an unknown
// extension
isCSV = false;
}
if (!isCSV) {
try {
auto it = s_sched->UniqueProcessedExternalFiles.emplace(state.files.TempFullFilePath.filePath,
FileSystem::readJSON(state.files.TempFullFilePath.filePath));
result = it.first;
ShowWarningMessage(state,
fmt::format("Extension of file {} is unrecogonized, but parsed as JSON successfully",
state.files.TempFullFilePath.filePath));
isJSON = true;
} catch (...) {
// We're testing to see if this is json, if any exception exists, then throw the standard error about an unknown
// extension
isJSON = false;
}
}
if (!isCSV && !isJSON) {
ShowSevereCustom(
state,
eoh,
format("{} = {} has an unknown file extension and cannot be read by this program.", cAlphaFields(3), Alphas(3)));
ShowFatalError(state, "Program terminates due to previous condition.");
}
Copy link
Contributor

@rraustad rraustad Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly better than it was.

}
}

Expand Down
Loading