Skip to content

Conversation

@sriharisundar
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 92.41877% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.11%. Comparing base (bdce00f) to head (26d3d92).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
PRASReport.jl/src/writedb.jl 92.30% 14 Missing ⚠️
PRASCore.jl/src/Results/Shortfall.jl 0.00% 4 Missing ⚠️
PRASReport.jl/src/events.jl 96.72% 2 Missing ⚠️
PRASCore.jl/src/Results/Results.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   84.10%   85.11%   +1.01%     
==========================================
  Files          42       46       +4     
  Lines        2001     2278     +277     
==========================================
+ Hits         1683     1939     +256     
- Misses        318      339      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hsunnrel hsunnrel requested a review from Copilot October 1, 2025 14:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new PRASReport.jl package to the PRAS ecosystem that generates interactive HTML reports for power system resource adequacy analysis results. The package extracts "events" (periods of energy shortfall above a threshold) from PRAS simulation results and creates visualizations using embedded databases and web technologies.

Key changes:

  • Implements event extraction and analysis from PRAS ShortfallResult objects
  • Creates interactive HTML reports with charts and tabular views using DuckDB WASM
  • Provides multiple input methods (results, system models, or file paths)

Reviewed Changes

Copilot reviewed 16 out of 18 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
PRASReport.jl/src/ Core package implementation with event extraction, database operations, and HTML report generation
PRASReport.jl/test/ Test suite covering event extraction and report generation workflows
PRASReport.jl/examples/ Example usage script
PRASCore.jl/src/Results/ Extension to support new NEUE calculations needed by reporting
.github/workflows/ CI configuration for the new package

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

regions::Vector{String}
) where {N,L,T,E}

length(lole) != length(eue) != length(neue) != length(regions) &&
Copy link

Copilot AI Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This chained inequality comparison doesn't work as intended in Julia. It should be length(lole) != length(eue) || length(eue) != length(neue) || length(neue) != length(regions) to check that all vectors have equal length.

Suggested change
length(lole) != length(eue) != length(neue) != length(regions) &&
(length(lole) != length(eue) || length(eue) != length(neue) || length(neue) != length(regions)) &&

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants