Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ $ pip install chronify

To use Apache Spark via Apache Thrift Server as the backend:
```
$ pip install chronify --group=pyhive
$ pip install "chronify[spark]"
```

## Developer installation
```
$ pip install -e ".[dev]" --group=pyhive
$ pip install -e ".[dev,spark]"
```

Please install `pre-commit` so that your code is checked before making commits.
Expand Down
3 changes: 2 additions & 1 deletion docs/how_tos/getting_started/installation.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,10 @@ To use DuckDB or SQLite as the backend:
```

To use Apache Spark via Apache Thrift Server as the backend, you must install pyhive.
This command will install the necessary dependencies.

```{eval-rst}
.. code-block:: console

$ pip install chronify --group=pyhive
$ pip install "chronify[spark]"
```
2 changes: 1 addition & 1 deletion docs/how_tos/spark_backend.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ scripts for UNIX operating systems (not Windows).

## Install chronify with Spark support
```
$ pip install chronify --group=pyhive
$ pip install "chronify[spark]"
```

## Installation on a development computer
Expand Down
7 changes: 3 additions & 4 deletions src/chronify/datetime_range_generator.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,9 @@ def __init__(
def _list_timestamps(self, time_zone: Optional[tzinfo]) -> list[datetime]:
"""always return tz-naive timestamps relative to input time_zone"""
if self._model.start_time_is_tz_naive():
if time_zone:
start = self._model.start.replace(tzinfo=time_zone)
else:
start = None
# For clock-time-aligned data, iterate naively without timezone conversion.
# All timezones get the same clock times (e.g., midnight everywhere).
start = None
else:
if time_zone:
start = self._model.start.astimezone(time_zone)
Expand Down