Kva back to transformer #172
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tarekelgindy
left a comment
tarekelgindy
left a comment
There was a problem hiding this comment.
I'd like to merge some of the other branches into master before we merge this one. The changes look good but there are some new modifications to the regulator writer in CYME (for instance) that should be merged first.
NicolasGensollen
force-pushed
the
kva-back-to-transformer
branch
from
0e5b7e7 to
248552a
Compare
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
==========================================
- Coverage 43.96% 43.94% -0.03%
==========================================
Files 74 74
Lines 16473 16383 -90
==========================================
- Hits 7243 7200 -43
+ Misses 9230 9183 -47
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to address the KVA issues described in #160
@tarekelgindy, this PR impacts basically all parsers so we probably should be very careful and test it (smartd-ds and others) before eventually merging.
NOTES:
Gridlab-Dparsers and theEphasorwriter but I'm not familiar with them, so double checking seems like a good idea