Skip to content

System structure modifier updates #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nlaws-camus wants to merge 21 commits into
base: master
Choose a base branch
from
Open

System structure modifier updates #407

nlaws-camus wants to merge 21 commits into from

Conversation

@nlaws-camus
Copy link
Collaborator

@nlaws-camus nlaws-camus commented Nov 8, 2022

The NetworkAnalyzer was using a method to set nominal voltages that said in its doc string:

warning:: Use set_nominal_voltages_recur instead.

So I have changed the NetworkAnalyzer to use set_nominal_voltages_recur.

Also some doc strings and formatting improvements. And removed a third method for setting nominal voltages that said:

warning:: DO NOT USE. Use set_nominal_voltages instead

@nlaws-camus
system_structure_modifier: delete method that has warning not to use it
0d2ca67 
_set_nominal_voltages seems to be the worst of three methods defined to set nominal voltages
@nlaws-camus
use the recommended system_structure_modifier.set_nominal_voltages_re…
8a10247 
…cur in NetworkAnalyzer
@nlaws-camus
refactor is not "" to correct != "" in NetworkAnalyzer
3ffe4e4
@nlaws-camus
rm broken, unused set_nominal_voltages in system_structure_modifier
4929915
@nlaws-camus
minor formatting in system_structure_modifier
1015822
@nlaws-camus
add debug msg when changing node nominal_voltage in system_structure_…
0aca2f5 
…modifier
@nlaws-camus
rm unused arg from Network.get_upstream_transformer
0f0a3a5
@nlaws-camus
update network_analysis.py doc string
499d951
@nlaws-camus
minor formatting in Network.__init__
642a8bf
@nlaws-camus
make warnings logger.warn (were logger.debug)
8e00e70
@nlaws-camus
system_structure_modifier: delete method that has warning not to use it
7ff8a18 
_set_nominal_voltages seems to be the worst of three methods defined to set nominal voltages
@nlaws-camus
use the recommended system_structure_modifier.set_nominal_voltages_re…
5672f83 
…cur in NetworkAnalyzer
@nlaws-camus
refactor is not "" to correct != "" in NetworkAnalyzer
0fa7227
@nlaws-camus
rm broken, unused set_nominal_voltages in system_structure_modifier
f319687
@nlaws-camus
minor formatting in system_structure_modifier
9a5e238
@nlaws-camus
add debug msg when changing node nominal_voltage in system_structure_…
3be9558 
…modifier
@nlaws-camus
rm unused arg from Network.get_upstream_transformer
06ba51b
@nlaws-camus
update network_analysis.py doc string
9300e45
@nlaws-camus
minor formatting in Network.__init__
411c518
@nlaws-camus
make warnings logger.warn (were logger.debug)
6b4396d
@nlaws-camus
Merge branch 'sys-struct-modifier-updates' of https://github.com/nlaw…
66414a8 
…s-camus/ditto into sys-struct-modifier-updates
@nlaws-camus nlaws-camus changed the base branch from master to Add-units-to-models November 18, 2022 21:00
@nlaws-camus nlaws-camus changed the base branch from Add-units-to-models to master November 18, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarekelgindy tarekelgindy Awaiting requested review from tarekelgindy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nlaws-camus