Skip to content

Conversation

@MYMahfouz
Copy link

@MYMahfouz MYMahfouz commented Jan 9, 2023

Feature or improvement description
Fixing the farm orientation before plotting, this pull request builds on the work done in an earlier pull request: #533

Related issue, if one exists
This pull request builds on the work done in an earlier pull request: #533
Fix orientation: #348, #357, #372
non-matching plot turbine with fi: #448, #451, #455, #512

Impacted areas of the software
utilities.py: fn rotate_coordinates_rel_west() adding 2 parameters (farm layout_x and layout_y)
florice_interface.py: updated calling rotate_coordinates_rel_west() within get_plane_of_points()
There other changes that I got from #533
fix orientation
v grid.py: class flowfiledplanar Grid method set_grid (Braoden flowfield, rotate mesh grid)
v utilities.py: ftn rotate_coordinates_rel_west() adding 1 parameter (inv_rot)
v floris_interface.py: method get_plane_of_points() (reverse rotating to north up)

Additional supporting information

Test results, if applicable

@MYMahfouz MYMahfouz changed the title Updating "rotate_coordinates_rel_west" function in utilities to fix farm orientation for plots Feature: Updating "rotate_coordinates_rel_west" function in utilities to fix farm orientation for plots Jan 9, 2023
@rafmudaf rafmudaf self-assigned this Feb 1, 2023
@rafmudaf rafmudaf force-pushed the main branch 2 times, most recently from 4285b96 to 76df862 Compare February 7, 2023 20:25
@rafmudaf
Copy link
Collaborator

@MYMahfouz Just heads up that I updated this branch and placed it (via git-rebase) on top of develop.

dhcho347 added a commit to dhcho347/floris that referenced this pull request May 4, 2023
@bayc
Copy link
Collaborator

bayc commented May 5, 2023

Hello, I believe this functionality has been integrated into some other work in #578. It would be great if you are able to check and verify that it does provide the same functionality you were aiming for here.

@misi9170
Copy link
Collaborator

misi9170 commented May 10, 2023

Hello, I believe this functionality has been integrated into some other work in #578. It would be great if you are able to check and verify that it does provide the same functionality you were aiming for here.

See also #650

@rafmudaf
Copy link
Collaborator

rafmudaf commented Jul 6, 2023

I'm closing this pull request since I think it is covered by #578 and #650 like @bayc and @misi9170 mentioned above. @MYMahfouz please update or reopen if this has been incorrectly closed.

@rafmudaf rafmudaf closed this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants