change ndarray dependency to ^0.16 for downstream compatibility #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarow
reviewed
Nov 25, 2025
Collaborator
|
It seems like my attempts to allow any 'actually compatible but not semver compatible' version of ndarray to be used are proving more of a headache for myself and downstream projects than a benefit. It's difficult/impossible to even get crates to unify the dependency if it isn't the latest major version anyway. I will go ahead and accept this PR and merge, thanks! Resolves #7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey @kylecarow, i think this range dependency isn't what you need here. i just read up and learned that range dependencies need to be supported transitively. so that means that compass also needs to support all ndarray versions in the range [0.15.3, 0.18.0).
this PR instead proposes you use a semver-compatible dependency declaration of ndarray versions matching 0.16.x. so that downstream users of ninterp can also import ndarray versions [0.16.0, 0.16.1] into their crate.
edit: everything i just said but "0.17" instead to match your benchmarking CI