-
Notifications
You must be signed in to change notification settings - Fork 77
Degradation timeseries plot - add left or right label option #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
3.0 Release
Bumps [notebook](https://github.com/jupyter/notebook) from 7.2.1 to 7.2.2. - [Release notes](https://github.com/jupyter/notebook/releases) - [Changelog](https://github.com/jupyter/notebook/blob/@jupyter-notebook/tree@7.2.2/CHANGELOG.md) - [Commits](https://github.com/jupyter/notebook/compare/@jupyter-notebook/tree@7.2.1...@jupyter-notebook/tree@7.2.2) --- updated-dependencies: - dependency-name: notebook dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bump notebook from 7.2.1 to 7.2.2 in /docs
Bumps [tornado](https://github.com/tornadoweb/tornado) from 6.4.2 to 6.5.1. - [Changelog](https://github.com/tornadoweb/tornado/blob/master/docs/releases.rst) - [Commits](tornadoweb/tornado@v6.4.2...v6.5.1) --- updated-dependencies: - dependency-name: tornado dependency-version: 6.5.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…nd 'center' labeling options.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development #456 +/- ##
===============================================
+ Coverage 96.26% 96.33% +0.06%
===============================================
Files 12 12
Lines 2276 2290 +14
===============================================
+ Hits 2191 2206 +15
+ Misses 85 84 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Outcome of our 6/17/25 PV Fleet meeting to review this PR: Yes, it seems that the default behavior is not ideal, given the 2-year gap from timeseries data start to time-dependent degradation rate. Best approach would be to use a timestamp in the center of the YoY slope, and use a window centered on the datapoint. If necessary, pad the dataframe with NaN's to account for the beginning of the time series that might not have enough points in the window. Possible other functions to investigate: scipy.ndimage.median_filter or np.convolve |
statsmodels 0.14.4 is not able to handle the latest scipy.
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.5 to 3.1.6. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@3.1.5...3.1.6) --- updated-dependencies: - dependency-name: jinja2 dependency-version: 3.1.6 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [requests](https://github.com/psf/requests) from 2.32.3 to 2.32.4. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.32.3...v2.32.4) --- updated-dependencies: - dependency-name: requests dependency-version: 2.32.4 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.2.2 to 2.5.0. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.2.2...2.5.0) --- updated-dependencies: - dependency-name: urllib3 dependency-version: 2.5.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bump jinja2 from 3.1.5 to 3.1.6 in /docs
remove scipy restrictions in setup.py now that statsmodels has a new release.
Bump urllib3 from 2.2.2 to 2.5.0
Bump requests from 2.32.3 to 2.32.4
Bump tornado from 6.4.2 to 6.5.1 in /docs
…o 3.0.1_candidate
3.0.1 patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This enhancement adds a label parameter to the degradation_timeseries_plot function, allowing users to control how the time series data is labeled on the plot. The change enables left, center, or right labeling options instead of only the previous default right labeling behavior.
- Adds
labelparameter with 'right', 'center', and 'left' options to control plot labeling - Updates documentation and changelog to reflect the new functionality
- Adds comprehensive test coverage for the new parameter options
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| rdtools/plotting.py | Implements the new label parameter with validation and offset calculations for different labeling positions |
| rdtools/test/plotting_test.py | Adds test cases covering all label options and error conditions |
| docs/sphinx/source/changelog/pending.rst | Documents the enhancement in the pending changelog |
| docs/sphinx/source/changelog.rst | Includes the pending changelog in the main changelog |
| docs/sphinx/source/changelog/v3.0.1.rst | Adds version 3.0.1 changelog entry |
| docs/notebook_requirements.txt | Updates dependency versions (Jinja2, tornado, notebook) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
… import in plotting.py, per Copilot review.
This enhancement fixes #455. Adds an input parameter 'label' to have the degradation timeseries plot either right-labeled (current default) or center or left-labeled. This is the first PR of three that is required to enable multi-Year-on-Year degradation analysis and plotting.
New functions added to__init__.pyExample notebooks are rerun and differences in results scrutinized