Skip to content

Conversation

@grantbuster
Copy link
Member

…s with spatial only datasets

@grantbuster grantbuster requested a review from ppinchuk April 23, 2025 15:37
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.73%. Comparing base (250162c) to head (d3c4280).

Files with missing lines Patch % Lines
rex/resource_extraction/resource_extraction.py 42.85% 2 Missing and 2 partials ⚠️

❌ Your patch status has failed because the patch coverage (42.85%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
+ Coverage   67.71%   67.73%   +0.01%     
==========================================
  Files          40       40              
  Lines        7091     7095       +4     
  Branches     1037     1039       +2     
==========================================
+ Hits         4802     4806       +4     
+ Misses       1962     1961       -1     
- Partials      327      328       +1     
Flag Coverage Δ
unittests 67.73% <42.85%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
rex/resource_extraction/resource_extraction.py 83.36% <42.85%> (+0.12%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@ppinchuk ppinchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems simple enough!

@grantbuster grantbuster merged commit e9099ff into main Apr 23, 2025
19 checks passed
@grantbuster grantbuster deleted the gb/subset branch April 23, 2025 18:33
github-actions bot pushed a commit that referenced this pull request Apr 23, 2025
minor edit to allow for save subset to work on complicated reV output…
github-actions bot pushed a commit to MRE-Code-Hub/rex that referenced this pull request Apr 23, 2025
minor edit to allow for save subset to work on complicated reV output…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants