Skip to content

Conversation

@ppinchuk
Copy link
Collaborator

in check_res_file function, if HSDS cannot be connected to (either service is unreachable or folder is incorrect), report that back to caller instead of erroring out

@ppinchuk ppinchuk self-assigned this May 23, 2025
@ppinchuk ppinchuk added enhancement Update to logic or general code improvements p-high Priority: high labels May 23, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.84%. Comparing base (99ba31a) to head (e2f5b56).

Files with missing lines Patch % Lines
rex/utilities/utilities.py 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
+ Coverage   67.70%   67.84%   +0.14%     
==========================================
  Files          40       40              
  Lines        7098     7101       +3     
  Branches     1040     1040              
==========================================
+ Hits         4806     4818      +12     
+ Misses       1964     1954      -10     
- Partials      328      329       +1     
Flag Coverage Δ
unittests 67.84% <80.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
rex/utilities/utilities.py 47.63% <80.00%> (+2.96%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ppinchuk ppinchuk merged commit a633b2a into main May 24, 2025
19 checks passed
@ppinchuk ppinchuk deleted the pp/hsds_failsafe branch May 24, 2025 00:35
github-actions bot pushed a commit that referenced this pull request May 24, 2025
Add fallback if accessing HSDS fails
github-actions bot pushed a commit to MRE-Code-Hub/rex that referenced this pull request May 24, 2025
Add fallback if accessing HSDS fails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Update to logic or general code improvements p-high Priority: high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants