Skip to content

Conversation

@ppinchuk
Copy link
Collaborator

super() call on class method was breaking. Instead, just re-order argument inputs and use default method implementation

@ppinchuk ppinchuk self-assigned this May 29, 2025
@ppinchuk ppinchuk added bugfix Fixes a bug p-medium Priority: medium labels May 29, 2025
@ppinchuk ppinchuk linked an issue May 29, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.95%. Comparing base (a633b2a) to head (c254093).

Files with missing lines Patch % Lines
rex/resource_extraction/wind_cli.py 25.00% 3 Missing ⚠️
rex/resource_extraction/resource_extraction.py 66.66% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (42.85%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
+ Coverage   67.84%   67.95%   +0.10%     
==========================================
  Files          40       40              
  Lines        7101     7097       -4     
  Branches     1040     1040              
==========================================
+ Hits         4818     4823       +5     
+ Misses       1954     1947       -7     
+ Partials      329      327       -2     
Flag Coverage Δ
unittests 67.95% <42.85%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
rex/resource_extraction/resource_extraction.py 84.88% <66.66%> (+1.51%) ⬆️
rex/resource_extraction/wind_cli.py 58.91% <25.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ppinchuk ppinchuk added the breaking Breaks something in the API or config label May 29, 2025
@ppinchuk ppinchuk merged commit 9ab611d into main May 29, 2025
19 checks passed
@ppinchuk ppinchuk deleted the pp/fix_resource_extraction branch May 29, 2025 05:36
github-actions bot pushed a commit that referenced this pull request May 29, 2025
Fix `make_SAM_files` method for `WindX`
github-actions bot pushed a commit to MRE-Code-Hub/rex that referenced this pull request May 29, 2025
Fix `make_SAM_files` method for `WindX`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Breaks something in the API or config bugfix Fixes a bug p-medium Priority: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in resource extraction

3 participants