Skip to content

Conversation

@ppinchuk
Copy link
Collaborator

Before writing tha attrs, make sure they don't already exist so that we don't clobber some user-defined attrs.

@ppinchuk ppinchuk self-assigned this Jul 11, 2025
@ppinchuk ppinchuk added bugfix Fixes a bug p-high Priority: high topic-resource-handler Issues/pull requests related to the main rex Resource handler labels Jul 11, 2025
@ppinchuk ppinchuk linked an issue Jul 11, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.99%. Comparing base (2f1a224) to head (96c9f40).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #225   +/-   ##
=======================================
  Coverage   67.98%   67.99%           
=======================================
  Files          40       40           
  Lines        7113     7114    +1     
  Branches     1043     1045    +2     
=======================================
+ Hits         4836     4837    +1     
  Misses       1948     1948           
  Partials      329      329           
Flag Coverage Δ
unittests 67.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
rex/outputs.py 63.37% <100.00%> (+0.11%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ppinchuk ppinchuk merged commit f185174 into main Jul 11, 2025
19 checks passed
@ppinchuk ppinchuk deleted the pp/outputs_fix branch July 11, 2025 23:15
github-actions bot pushed a commit that referenced this pull request Jul 11, 2025
Fix attrs in Outputs getting overwritten
github-actions bot pushed a commit to MRE-Code-Hub/rex that referenced this pull request Jul 11, 2025
Fix attrs in Outputs getting overwritten
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes a bug p-high Priority: high topic-resource-handler Issues/pull requests related to the main rex Resource handler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Outputs overwrite attrs anytime they are opened in writeable mode

3 participants