Skip to content

Conversation

@onel
Copy link

@onel onel commented Dec 18, 2025

What does this PR do ?

I saw version 0.2.0 adds support for chat datasets with open ai format.
This PR adds the necessary documentation for this new feature.

Changelog

  • one documentation update

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 18, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@akoumpa akoumpa requested a review from HuiyingLi December 19, 2025 00:01
@HuiyingLi HuiyingLi changed the title Add documentation for the new ChatDataset class docs: Add documentation for the new ChatDataset class Dec 19, 2025
@akoumpa akoumpa requested a review from jgerh December 19, 2025 12:07
@akoumpa akoumpa added the docs-only With great power comes great responsibility. label Dec 19, 2025
Copy link
Contributor

@jgerh jgerh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed the tech pubs review and provided a few copyedits and suggested text revisions

onel and others added 9 commits December 22, 2025 19:04
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com>
@onel
Copy link
Author

onel commented Dec 22, 2025

Thanks for all the edits @jgerh. Looking much better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-request docs-only With great power comes great responsibility.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants