Properly Handle DynamicInferenceRequestRecord with latest Mcore #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ao Tang <aot@nvidia.com>
suiyoubi
requested review from
athitten,
oyilmaz-nvidia and
pthombre
as code owners
Contributor
|
@suiyoubi Could you please fix the linting issues? Then we can start the CI. |
Contributor
|
/ok to test bc17765 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest versions of Megatron-Core's inference engine return
DynamicInferenceRequestRecordobjects instead ofInferenceRequestobjects. TheDynamicInferenceRequestRecordis a container class that holds multipleDynamicInferenceRequestobjects (to support suspend/resume functionality) and doesn't have a direct generated_text attribute.Added handling after generate() to merge DynamicInferenceRequestRecord objects in this PR