Make WeightedAggregationHelper memory efficient #3884
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description
Key Optimizations:
v.clone().mul_(weight)instead ofv * weight- this creates only one copy instead of an intermediate tensor.add_(v, alpha=weight)which is equivalent to+= v * weightbut done in-place without creating any intermediate tensors. This is the biggest memory saver.div_(self.counts[k])for in-place division instead of creating a new tensor with multiplication.Memory Savings:
For N clients with model size M:
For a large model (e.g., 1B parameters as float32 = 4GB), this saves approximately 4-8GB of peak memory during aggregation with just a few clients.
Types of changes
./runtest.sh.