-
Notifications
You must be signed in to change notification settings - Fork 228
[Doc] Flare Overview, System architect updates and new how-to guide structure [skip ci] #3922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Greptile SummaryThis PR comprehensively restructures and expands the NVFLARE documentation to improve discoverability, clarity, and user experience. The changes include: Major Structural Improvements:
New Documentation Added:
Documentation Quality:
The changes align well with the PR description's stated goals and significantly improve the documentation's organization and accessibility for different user personas (data scientists, FL researchers, system integrators). Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant MainIndex as Main Index (index.rst)
participant FlareOverview as FLARE Overview
participant SysArch as System Architecture Section
participant HowToGuide as How-to Guide Section
participant DevGuides as Development Guides
participant ProdGuides as Production Guides
User->>MainIndex: Navigate to documentation
MainIndex->>FlareOverview: Enhanced overview with expanded features
Note over FlareOverview: Rewritten with better structure<br/>Cross-silo & cross-device support<br/>Industry use cases added
MainIndex->>SysArch: New visible architecture section
Note over SysArch: System Architecture<br/>Security Overview<br/>Cellnet Architecture<br/>Design Principles
MainIndex->>HowToGuide: New task-oriented guide structure
HowToGuide->>DevGuides: Development guides
Note over DevGuides: Different FLARE APIs<br/>DL to FL Conversion<br/>Federated Analytics<br/>Simulation
HowToGuide->>ProdGuides: Production guides
Note over ProdGuides: Setup NVFLARE<br/>Deploy to AWS/Azure<br/>System Monitoring<br/>Interact with FLARE
|
Greptile found no issues!From now on, if a review finishes and we haven't found any issues, we will not post anything, but you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
docs/programming_guide/execution_api_type/client_api.rst, line 194 (link)syntax: incorrect reStructuredText syntax - triple backticks don't create references in RST
16 files reviewed, 1 comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
docs/system_architecture/design_principals.rst, line 1-2 (link)style: Filename typo:
design_principals.rstshould bedesign_principles.rst(principal vs principle)
25 files reviewed, 1 comment
|
/build |
|
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (9)
-
docs/hello-world/hello-tf/index.rst, line 56 (link)syntax: Directory name should be 'hello-tf' not 'hello-pt' to match the actual example being documented
-
docs/index.rst, line 38 (link)logic: Duplicate confidential computing reference - line 18 adds
user_guide/confidential_computing/indexto Introduction section, but line 38 still has the oldconfidential_computing/indexentry in Guides section. Should the confidential_computing/index entry on line 38 be removed since it's now included in the Introduction section on line 18? -
docs/programming_guide/flare_api_evolution.rst, line 44 (link)syntax: Missing period at end of sentence
-
docs/programming_guide/flare_api_evolution.rst, line 150 (link)syntax: Missing article 'a' before 'job'
-
docs/hello-world/hello-tabular-stats/index.rst, line 96 (link)syntax: Markdown link syntax
[adult dataset](https://archive.ics.uci.edu/dataset/2/adult)is incorrect for RST format -
docs/hello-world/hello-tabular-stats/index.rst, line 204-206 (link)syntax: Markdown-style headers
## Visualizationare incorrect for RST format -
docs/programming_guide/execution_api_type/client_api.rst, line 69 (link)syntax: Incomplete sentence - missing completion after 'job Recipe and the'
-
docs/how-to-guide/production/setup_nvflare.rst, line 209 (link)style: Uses
@in email addresses without code formattingNote: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
-
docs/how-to-guide/develop/fed_analytics.rst, line 23 (link)logic: mentions min and max as common outputs but line 46 states they're excluded for privacy
29 files reviewed, 9 comments
|
/build |
Description
Types of changes
./runtest.sh.