Skip to content
This repository was archived by the owner on Nov 19, 2025. It is now read-only.

Conversation

@rohitrango
Copy link
Contributor

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

rohitrango and others added 3 commits August 26, 2024 10:52
Signed-off-by: Rohit Jena <rohit.rango@gmail.com>
Signed-off-by: Rohit Jena <rohit.rango@gmail.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 26, 2024
@rohitrango
Copy link
Contributor Author

@JRD971000 @terrykong

@JRD971000 JRD971000 self-requested a review August 30, 2024 18:49
@rohitrango
Copy link
Contributor Author

  • remove scripts
  • remove local paths

rohitrango and others added 2 commits September 5, 2024 16:08
JRD971000
JRD971000 previously approved these changes Sep 5, 2024
@JRD971000 JRD971000 requested a review from terrykong September 5, 2024 23:37
care of the merging of the two scripts

Also changed the weighting function, timer defaults, and relative paths
for saving images

Signed-off-by: Rohit Jena <rohit.rango@gmail.com>
functionality

Signed-off-by: Rohit Jena <rohit.rango@gmail.com>
…er into draftp_anneal_docs

Signed-off-by: Rohit Jena <rohit.rango@gmail.com>
@terrykong terrykong merged commit da3f5f8 into NVIDIA:main Sep 6, 2024
abukharin3 pushed a commit to abukharin3/NeMo-Aligner that referenced this pull request Sep 25, 2024
Signed-off-by: Rohit Jena <rohit.rango@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Alexander Bukharin <abukharin@abukharin-mlt.client.nvidia.com>
abukharin3 pushed a commit to abukharin3/NeMo-Aligner that referenced this pull request Nov 7, 2024
Signed-off-by: Rohit Jena <rohit.rango@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants