Skip to content
This repository was archived by the owner on Nov 19, 2025. It is now read-only.

Conversation

@ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Nov 22, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

terrykong and others added 2 commits November 20, 2024 20:27
)

Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: NeMo-Aligner CI <nemo-aligner-ci@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added the Run CICD Set + un-set to retrigger (add after r*.*.* labels) label Nov 22, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger (add after r*.*.* labels) and removed Run CICD Set + un-set to retrigger (add after r*.*.* labels) labels Nov 22, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger (add after r*.*.* labels) and removed Run CICD Set + un-set to retrigger (add after r*.*.* labels) labels Nov 22, 2024
pre-commit-ci bot and others added 2 commits November 22, 2024 10:39
for more information, see https://pre-commit.ci

Signed-off-by: NeMo-Aligner CI <nemo-aligner-ci@nvidia.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger (add after r*.*.* labels) and removed Run CICD Set + un-set to retrigger (add after r*.*.* labels) labels Nov 22, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger (add after r*.*.* labels) and removed Run CICD Set + un-set to retrigger (add after r*.*.* labels) labels Nov 22, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger (add after r*.*.* labels) and removed Run CICD Set + un-set to retrigger (add after r*.*.* labels) labels Nov 22, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger (add after r*.*.* labels) and removed Run CICD Set + un-set to retrigger (add after r*.*.* labels) labels Nov 22, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger (add after r*.*.* labels) and removed Run CICD Set + un-set to retrigger (add after r*.*.* labels) labels Nov 22, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger (add after r*.*.* labels) and removed Run CICD Set + un-set to retrigger (add after r*.*.* labels) labels Nov 22, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger (add after r*.*.* labels) and removed Run CICD Set + un-set to retrigger (add after r*.*.* labels) labels Nov 22, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger (add after r*.*.* labels) and removed Run CICD Set + un-set to retrigger (add after r*.*.* labels) labels Nov 22, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger (add after r*.*.* labels) and removed Run CICD Set + un-set to retrigger (add after r*.*.* labels) labels Nov 22, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger (add after r*.*.* labels) and removed Run CICD Set + un-set to retrigger (add after r*.*.* labels) labels Nov 22, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g removed the Run CICD Set + un-set to retrigger (add after r*.*.* labels) label Nov 22, 2024
for more information, see https://pre-commit.ci

Signed-off-by: NeMo-Aligner CI <nemo-aligner-ci@nvidia.com>
@ko3n1g ko3n1g added the Run CICD Set + un-set to retrigger (add after r*.*.* labels) label Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Run CICD Set + un-set to retrigger (add after r*.*.* labels)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants