-
Notifications
You must be signed in to change notification settings - Fork 42
Provide CMS-friendly documentation build #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7bad653
Fully migrate from MD to RST for documentation
amaslenn 3fb9d95
Update copyright year
amaslenn e004bbb
Build CMS-friendly documentation
amaslenn 984b0f8
Add missing uv lock sync
amaslenn baa0b7c
Avoid double zipping
amaslenn 5e31183
Address review comments
amaslenn 0df2379
Avoid sphinx warning
amaslenn a54a375
Fix CMS doc build
amaslenn a8aa36d
Address review comments
amaslenn 07b1bc8
Address review comments
amaslenn 5d5ddb9
Trigger docs deployment based on tags creation
amaslenn 0917b18
Sanitize artifact name
amaslenn 18f3d8c
Address review comments
amaslenn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| Development | ||
| =========== | ||
|
|
||
| This document targets developers who want to contribute to the project's core. | ||
|
|
||
| .. mermaid:: | ||
|
|
||
| graph TD | ||
| subgraph _core | ||
| base_modules | ||
| core_implementations | ||
| registry | ||
| end | ||
|
|
||
| subgraph runners | ||
| SlurmRunner | ||
| StandaloneRunner | ||
| end | ||
|
|
||
| subgraph installers | ||
| SlurmInstaller | ||
| StandaloneInstaller | ||
| end | ||
|
|
||
| subgraph systems | ||
| SlurmSystem | ||
| StandaloneSystem | ||
| end | ||
|
|
||
| installers --> _core | ||
| runners --> _core | ||
| systems --> _core | ||
|
|
||
| Core Modules | ||
| ------------ | ||
|
|
||
| We use `import-linter <https://github.com/seddonym/import-linter>`_ to ensure no core modules import higher level modules. | ||
|
|
||
| ``Registry`` object is a singleton that holds implementation mappings. Users can register their own implementations to the registry or replace the default implementations. | ||
|
|
||
| Cache | ||
| ----- | ||
|
|
||
| Some prerequisites can be installed. For example: Docker images, git repos with executable scripts, etc. All such "installables" are kept under system ``install_path``. | ||
|
|
||
| Installables are shared among all tests. So if any number of tests use the same installable, it is installed only once for a particular system TOML. | ||
|
|
||
| .. mermaid:: | ||
|
|
||
| classDiagram | ||
| class Installable { | ||
| <<abstract>> | ||
| + __eq__(other: object) | ||
| + __hash__() | ||
| } | ||
|
|
||
| class DockerImage { | ||
| + url: str | ||
| + install_path: str | Path | ||
| } | ||
|
|
||
| class GitRepo { | ||
| + git_url: str | ||
| + commit_hash: str | ||
| + install_path: Path | ||
| } | ||
|
|
||
| class PythonExecutable { | ||
| + git_repo: GitRepo | ||
| + venv_path: Path | ||
| } | ||
|
|
||
| Installable <|-- DockerImage | ||
| Installable <|-- GitRepo | ||
| Installable <|-- PythonExecutable | ||
| PythonExecutable --> GitRepo | ||
|
|
||
| class BaseInstaller { | ||
| <<abstract>> | ||
| + install(items: Iterable[Installable]) | ||
| + uninstall(items: Iterable[Installable]) | ||
| + is_installed(items: Iterable[Installable]) -> bool | ||
|
|
||
| * install_one(item: Installable) | ||
| * uninstall_one(item: Installable) | ||
| * is_installed_one(item: Installable) -> bool | ||
| } | ||
|
|
||
| BaseInstaller <|-- SlurmInstaller | ||
| BaseInstaller <|-- StandaloneInstaller | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.