operand: Updates to cc-manager and sandbox-device-plugin #2054
Conversation
Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
…dling CDI spec creation Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
zvonkok
requested review from
cdesiniotis,
elezar,
shivamerla and
tariq1890
as code owners
There was a problem hiding this comment.
Pull request overview
This PR updates the operand configurations for cc-manager and sandbox-device-plugin to align with updated functionality. The sandbox-device-plugin now handles CDI (Container Device Interface) spec creation internally, requiring access to the CDI specification directory. The cc-manager changes remove a hardcoded device ID list in favor of the dynamic configuration approach already implemented in the operator.
Changes:
- Added
/var/run/cdivolume mount to sandbox-device-plugin for CDI spec management - Removed hardcoded
CC_CAPABLE_DEVICE_IDSenvironment variable from cc-manager daemonset template
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| assets/state-sandbox-device-plugin/0500_daemonset.yaml | Added cdi-root volume and mount to enable CDI spec creation by the device plugin |
| assets/state-cc-manager/0500_daemonset.yaml | Removed obsolete hardcoded CC_CAPABLE_DEVICE_IDS environment variable (now configured via values.yaml and applied by operator) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cdesiniotis
left a comment
cdesiniotis
left a comment
There was a problem hiding this comment.
LGTM. Left one minor comment, will trigger the CI once addressed.
| - name: cdi-root | ||
| hostPath: | ||
| path: /var/run/cdi | ||
| type: DirectoryOrCreate |
There was a problem hiding this comment.
nit: let's add the newline back
4 participants
sandbox-device-plugin: Add /var/run/cdi mount since the DP is now handling CDI spec creation
cc-manager: Remove obsolete CC_CAPABLE_DEVICE_IDS