-
Notifications
You must be signed in to change notification settings - Fork 96
New feat : add a tools for species management #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Interesting - I'll see if I find time to look into this one further |
|
Really cool! |
Nachtzuster
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good.
One thing you probably are not aware of is that I've been working to move away from using common name and instead using scientific name. (Common names can change if somebody contributes improved translations or even switching between models)
It would be nice if new code is 'common name agnostic' as it were.
|
BTW Future idea: it would be nice if we somehow logged the "Excluded as below Species Occurrence Frequency Threshold" detections and marked those species as such on this page |
Removed the generateMiniGraph function and its associated AJAX call for fetching detections. This change may affect how mini graphs are displayed on the page.
Removed the generateMiniGraph function and its associated logic.
Add symbolic link for confirmed species list.
|
Hi, I've done the modifications and tested it as functional on my system, thanks for the recommendations. Regarding your proposal, the easiest might be to :
That way individual observations are not saved which could greatly bloat the system, but there is still a trace. What do you think of this proposal. The best would be to keep the one with max confidence just in case for user review but I fear this introduces a whole new level of complexity |
|
Tested a bit, found a couple of issues:
|
|
Thanks for the review.
root@db21ed7f-birdnet-pi:/mnt/NAS/Birdnet# find . -type f -name "grand-gravelot" | wc -l |
Updated file and directory deletion methods to use 'exec' for sudo commands and handle errors appropriately.
|
Thanks, I've now implemented the sudo rm with the same logic as play.php, and modified the code to still show the deletion message using common name as it should be more user friendly, while keeping the deletion logic based on sci name |
Refactor deletion logic to count deleted files instead of iterating through them.
Removed htmlspecialchars encoding for common and scientific names, and adjusted last seen display.
|
Thanks for the review, I've made some changes but wanted a double check on :
|
Not sure if this is a question, but my take is this:
|
Thanks. For 2., it was to prevent someone deleting data by typing an url directly in the address bar instead of using the script, but I can remove it. For me then it will be ready to merge! |
Removed the check for directory under base before deletion.
I understand that, I just struggle to see via which code path that is possible - but I did write the code, so I might be overlooking something, if you can confirm either way, that would be great. edit: if you can confirm there is no code path, then please remove |
|
Well it would be possible to delete any species with species_tools.php?delete=<Sci_Name> but indeed the user would still need to be authenticated. I'll remove the code |
Removed the under_base function to simplify path checks.
|
Thanks! |

This adds a new tab to the tools allowing to have an overview of all detected species
Objective : easily review anomalous species (low number of observations ; high number of observations but low max confidence, high number of observations but low threshold) and delete all linked sqlite lines and local files if needed. For species that we consider as actual observations, we can confirm them in the "confirmed file" that is created upon usage
Features :
Implement : php + using existing python scripts