-
Notifications
You must be signed in to change notification settings - Fork 27
Unit fuel meters #2138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: battery-resilience-refactor
Are you sure you want to change the base?
Unit fuel meters #2138
Conversation
HPXMLtoOpenStudio/measure.rb
Outdated
| Outputs.create_unit_fuel_meter(model, EPlus::FuelTypeElectricity, 'ElectricityProduced:Facility') | ||
| Outputs.create_unit_fuel_meter(model, EPlus::FuelTypeElectricity, 'ElectricStorage:ElectricityProduced') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using these meters is motivated by resilience calculations for batteries. Should we additionally create unit meters for MeterCustomElectricityTotal, MeterCustomElectricityNet, and MeterCustomElectricityPV so that we can support reporting out Electricity Total and Net for each unit?
Fuel Use: Unit1: Electricity: Total (MBtu), x
Fuel Use: Unit1: Electricity: Net (MBtu), y
Fuel Use: Unit1: Natural Gas: Total (MBtu), z
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. We call create_custom_meters for each unit model in addition to calling create_custom_meters on the merged model.
…tal and Net for each unit.
|
We should think about how this interacts with modeling central/shared systems. |
docs/source/workflow_outputs.rst
Outdated
| Fuel Use: Coal: Total (MBtu) Includes "coal", "anthracite coal", "bituminous coal", and "coke" | ||
| ==================================== =========================== | ||
|
|
||
| Annual Energy by Fuel Use by Unit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe unit-level outputs should be reported in a separate, e.g., results_annual_by_unit.csv file? If in the future we decided to report more than just energy use by fuel type, the results_annual.csv file may grow annoyingly long...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another idea is to just append unit-level outputs to the end of results_annual.csv. That way, results become more detailed as you scroll deeper into the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion, but appending unit-level outputs to the end of results_annual.csv seems reasonable to me.
Pull Request Description
Addresses #1499. Adds custom meters to calculate energy use for each dwelling unit.
Checklist
Not all may apply:
EPvalidator.sch) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run