-
Notifications
You must be signed in to change notification settings - Fork 1
fix(sync): fixing sync command and enhancing ipython Cli #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Remove PackageAstCache::build() that parsed ALL Python files upfront - Add targeted file-by-file parsing for entry points only - Add ast-grep CLI fallback for finding Plugin classes when entry_points.txt is missing - Add on-demand config class search using ast-grep pattern matching - Add serde_json dependency for parsing ast-grep JSON output This fixes the sync time regression from <30ms to ~2900ms by only parsing the 2-5 entry point files actually needed instead of all 50+ files in a package. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Consolidate imports and remove redundant local use statements - Extract is_skipped_param() helper to deduplicate param filtering logic - Simplify find_config_in_common_locations() with filename array - Convert extract_params_from_match() to functional filter_map style - Simplify argument_to_config_field() using existing clean_default_value - Make io_contract_for_kind() match exhaustive, merge identical arms - Simplify extract_class_init_params() with early return pattern Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
@pesap I can't really test this on my end. The plugins aren't being discovered anymore. mwebb@mwebb-43264s r2x-cli % cargo run list r2x-plexos-to-sienna: v0.0.0 r2x-reeds: v0.3.3 r2x-reeds-to-plexos: v0.0.0 r2x-reeds-to-sienna: v0.0.0 r2x-sienna: v0.1.0 r2x-sienna-to-plexos: v0.0.0 Total plugin packages: 7 |
Can you try with the plugins on this branch? NatLabRockies/r2x-reeds#41 |
Still the same issue. I only see the top level packages and not the individual plugins like upgrader, parser, etc. |
This PR also updates the simplified discovery process for r2x-core. See NatLabRockies/r2x-core#76
Sync vibe coded. Can you check it meets our criteria? @micahpw