Add service-data in advertisements

[rohitsangwan01]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @rohitsangwan01, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the universal_ble plugin by integrating the capability to retrieve and expose Bluetooth Low Energy (BLE) service data from advertisement packets. This feature provides more granular information about advertising devices, allowing applications to react to specific service-related data broadcasted by BLE peripherals. The changes involve updating the core data structures, implementing platform-specific data parsing, and ensuring proper data flow through the Pigeon messaging system.

Highlights

• Core Data Model Update: The UniversalBleScanResult model across all platforms (Android, iOS, Linux, Web, Windows) and the core BleDevice model in Dart have been extended to include a serviceData field, allowing for the capture of service-specific advertisement data.
• Platform-Specific Service Data Extraction: New logic has been implemented in the Android, iOS, Linux, Web, and Windows platform-specific code to parse and extract serviceData from BLE advertisement packets, handling various UUID formats on Windows.
• Pigeon Integration: The Pigeon-generated code has been updated to correctly serialize and deserialize the new serviceData field for seamless cross-platform communication between Dart and native code.
• Example App Enhancement: The example application now includes a temporary display for the newly exposed serviceData to aid in testing and verification of the implemented feature.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully adds support for service-data in BLE advertisements across all supported platforms. The changes are consistent, introducing the serviceData field to scan result models and implementing the necessary parsing logic for each platform's native BLE framework. My review includes suggestions to enhance code clarity and maintainability in the Swift, Dart (for Linux), and C++ (for Windows) implementations by refactoring verbose or complex code blocks into more concise and idiomatic forms.

[Copilot]

Pull request overview

This pull request adds support for extracting and exposing service data from BLE advertisements across all supported platforms (Windows, Darwin/iOS/macOS, Android, Linux, and Web).

Changes:

• Added serviceData field (Map<String, Uint8List>) to scan result data structures across all platforms
• Implemented service data extraction from advertisement data sections for 16-bit, 32-bit, and 128-bit UUIDs on Windows
• Updated pigeon-generated code to include the new service data field
• Added temporary debug UI in example app to display service data

Reviewed changes

Copilot reviewed 13 out of 17 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
windows/src/universal_ble_plugin.cpp	Implements service data extraction from advertisement data sections, handling 16/32/128-bit UUID formats
windows/src/generated/universal_ble.g.h	Adds service_data field to UniversalBleScanResult class declaration
windows/src/generated/universal_ble.g.cpp	Implements getter/setter methods for service_data and updates serialization
pigeon/universal_ble.dart	Adds serviceData field to UniversalBleScanResult pigeon definition
lib/src/universal_ble_web/universal_ble_web.dart	Extracts service data from web BLE advertisements
lib/src/universal_ble_pigeon/universal_ble_pigeon_channel.dart	Maps service data from pigeon to BleDevice
lib/src/universal_ble_pigeon/universal_ble.g.dart	Updates generated Dart pigeon code for service data
lib/src/universal_ble_linux/universal_ble_linux.dart	Adds serviceDataMap extension method and populates service data
lib/src/models/ble_device.dart	Adds serviceData field to BleDevice model
darwin/Classes/UniversalBlePlugin.swift	Extracts service data from CBAdvertisement data dictionary
darwin/Classes/UniversalBle.g.swift	Updates generated Swift pigeon code for service data
android/src/main/kotlin/com/navideck/universal_ble/UniversalBlePlugin.kt	Passes service data to scan results
android/src/main/kotlin/com/navideck/universal_ble/UniversalBleHelper.kt	Adds serviceData extension property for ScanResult
android/src/main/kotlin/com/navideck/universal_ble/UniversalBle.g.kt	Updates generated Kotlin pigeon code for service data
example/lib/home/widgets/scanned_item_widget.dart	Adds temporary debug display for service data
example/pubspec.lock	Updates version from 1.1.0 to 1.2.0
example/macos/Podfile.lock	Updates pod checksums

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.