Skip to content

Conversation

@fotiDim
Copy link
Contributor

@fotiDim fotiDim commented Jan 18, 2026

Update the peripheral detail page to format and display discovered services more clearly, including characteristics.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fotiDim, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the user experience on the peripheral detail page by enhancing how discovered Bluetooth services and their characteristics are presented. It introduces a structured, human-readable format for displaying this information and refactors the 'Copy Services' functionality to leverage this new format, while also relocating the button to a more intuitive position within the UI.

Highlights

  • Enhanced Service Formatting: Discovered services and their characteristics are now displayed in a more detailed and human-readable format, including characteristic UUIDs and their properties.
  • Relocated 'Copy Services' Button: The 'Copy Services' button has been moved from the main peripheral detail page to the header of the Services panel for better UI organization.
  • Improved Copy Functionality: The 'Copy Services' button now copies the newly formatted, detailed service and characteristic information to the clipboard, rather than just service UUIDs.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively improves the user experience by providing a more detailed format for discovered services and relocating the 'Copy Services' button for better accessibility. The new _formattedServices method is a great addition for creating a human-readable representation of services and characteristics.

My review includes a few suggestions to enhance the code quality:

  • Refactoring duplicated logic for copying services into a separate method to improve maintainability.
  • Simplifying the construction of a log message to make it more readable.
  • Removing a redundant check in the ServicesSideWidget.

These changes will make the code cleaner and easier to maintain. Overall, this is a solid improvement.

…rvices more clearly, including characteristics.
@fotiDim fotiDim force-pushed the Improved-services-copying branch from 8078f78 to 6b28003 Compare January 18, 2026 16:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the presentation of discovered BLE services by adding formatted output that includes both services and their characteristics with properties. The "Copy Services" button has been relocated from the Device Actions panel to the Services panel header for better UX.

Changes:

  • Added a _formattedServices method that creates human-readable output showing services with nested characteristics and their properties
  • Moved the "Copy Services" button from Device Actions to the Services panel header as an icon button
  • Updated service discovery logs to use the new formatted output for better readability

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
example/lib/peripheral_details/widgets/services_side_widget.dart Added optional onCopyServices callback parameter and integrated a copy icon button in the Services panel header
example/lib/peripheral_details/peripheral_detail_page.dart Implemented _formattedServices method for detailed service formatting, added _copyServicesToClipboard method, refactored service discovery logging to use formatted output, removed old "Copy Services" button from Device Actions, and wired up the new copy functionality
example/CHANGELOG.md Documented the button relocation and enhanced services formatting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fotiDim fotiDim force-pushed the Improved-services-copying branch from 2f46844 to 12345fe Compare January 18, 2026 19:24
@fotiDim fotiDim merged commit bcfb0ad into main Jan 19, 2026
2 checks passed
@fotiDim fotiDim deleted the Improved-services-copying branch January 19, 2026 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants