-
-
Notifications
You must be signed in to change notification settings - Fork 256
Dataset Tools Rework #749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
O-J1
wants to merge
94
commits into
Nerogar:master
Choose a base branch
from
O-J1:dataset-and-samples-rework
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Dataset Tools Rework #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sampling logic more defensive
…or Caption model too. (To work more reliably)
…nto appropriate classes.
…fy progress constants and make window taller.
…ject.toml to make it installable avoiding sys.path hack
- add BulkCaptionEdit tests
- Make MaksByColor.py go from 2.0s/it to 1.2s ish - fix SAMdream masking regression
Collaborator
Author
|
Its absolutely not perfect but it works satisfactorily now. Marking ready for review. Many changes and refactors will probably have to happen but I am committed to this being merged at some point. |
Nerogar
requested changes
Jul 13, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the ongoing complaints/requests about captioning, I decided it was time for a comprehensive (and final) overhaul. The PR is currently marked as a draft since I fully expect Johnny to point out numerous issues or questionable decisions that deserve attention. To users reading this; OT will never be as focused as other dedicated tools, this is at the limit.
Additions:
Initially, this PR was also supposed to include a samples rework, but the effort involved was beyond my expectations just reaching the current stage. I've self-reviewed it as best I can, but after looking at it for so long, I'm certain Ive become blind to some things.
If someone knows a well tested, lightweight ish photoreal replacement for Blip2, then I am open to outright replacing it but you have to provide lots of examples (preferably a peer reviewed paper)
P.S After this update, aside from major model improvements or truly groundbreaking developments (not incremental tweaks), I personally won't be addressing further data tool requests—and based on Nero's recent comments, I doubt he will either.