Improvement of autoExportPolicy functionality with CustomExportClientIPs to support clusters behind a SNAT. #1051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or pushing custom IPs/Networks to Export Policy with AutoExportPolicy.
custom export client ips
in TridentBackendConfig to enable and disable custom rules and have functionality based on it.
added EnableCustomExportPolicySettings where needed
nikos445
force-pushed
the
customExportPolicyClientIps
branch
from
04eccf1 to
85abe59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Improvement of
autoExportPolicyto be able, to add custom Client IPs to SVM export policies, using a variable inTridentBackendConfignamedcustomExportClientIPsAdd missing code for
ReconcileVolumeNodeAccess, for volume policies when backend updatesAdd extra variable
enableCustomExportPolicySettingsfor enable/disable custom export policy settings(currently enables/disables only CustomExportClientIPs but may create more in future)
Project tracking
N/A
Do any added TODOs have an issue in the backlog?
N/A
Did you add unit tests? Why not?
No, I can't test it in my environment.
Does this code need functional testing?
Yes, someone from Netapp please implement proper testing. I tested all code manually.
Is a code review walkthrough needed? why or why not?
Yes, not an expert in Netapp Trident Operator, but did my best to follow patterns based on existing code.
Should additional test coverage be executed in addition to pre-merge?
Does this code need a note in the changelog?
Yes
Does this code require documentation changes?
Yes
Additional Information
Related Issue: #1048