Skip to content

Reusable buffer for backup uploading #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
clohfink wants to merge 5 commits into
base: 4.x
Choose a base branch
from
Open

Reusable buffer for backup uploading #1117

clohfink wants to merge 5 commits into from

Conversation

@clohfink
Copy link

@clohfink clohfink commented Aug 9, 2025 •
edited
Loading

Metric byte[] impl ByteBuffer impl Change
Throughput (ops/ms) 0.414 (+/- 0.083) 0.890 (+/- 0.058) 2.15x faster
Throughput (ops/s) 414 890 +476 ops/s
Alloc per op (B/op) 3,092,129.6 B/op 2,421.4 B/op 1277x less
Alloc per op (MiB/op) ~2.95 MiB/op ~0.0023 MiB/op ~99.92% reduction
GC alloc rate (MB/s) 1,043.3 1.76 593x less
GC count 12 1 91.7% fewer GCs
GC time (ms) 14 5 64.3% less time in GC

@clohfink clohfink changed the base branch from 3.x to 4.x August 9, 2025 18:42
Copilot AI reviewed Aug 12, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@clohfink clohfink requested a review from Copilot August 13, 2025 16:54
Copilot AI reviewed Aug 13, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mattl-netflix mattl-netflix Awaiting requested review from mattl-netflix

@chengw-netflix chengw-netflix Awaiting requested review from chengw-netflix

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@clohfink