Feature/search dialog keyboard nav #34
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for nb-search-portal failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a solution to the keyboard nav, it's not super Reacty though so I'm not loving it. It just shifts the focus +/-1 element based on the arrow key pressed. The browser then attempts to keep the focused element visible in the container by scrolling automatically.
react-windowdoesn't really provide an easy way to get the dom element of a list item based on its index, so this workaround looks at all of the list items in the current window to see if one of them matches the currently focused element. If it does, it takes the neighboring element in the array (+/-1 depending on direction) and sets the new focus to that.