Skip to content
This repository was archived by the owner on Aug 12, 2025. It is now read-only.

Conversation

@mzcydev
Copy link
Member

@mzcydev mzcydev commented Jul 9, 2025

No description provided.

@mzcydev mzcydev requested a review from Copilot July 9, 2025 11:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Merge updates from master into dev to unify version templating, messaging, auto-update logic, command handling, and CI workflows.

  • Switched plugin.yml to use a ${version} placeholder and added messages.yml and config.yml for runtime configuration.
  • Enhanced CoreAutoUpdater to support prerelease (“-SNAPSHOT”) channels and asynchronous downloads.
  • Introduced NextCoreCommand for core plugin commands and integrated it in NextCorePlugin.
  • Updated GitHub Actions workflows to extract versions from the JAR, handle prereleases, and add Qodana code-quality checks.

Reviewed Changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/main/resources/plugin.yml Use ${version} placeholder instead of hardcoded version
src/main/resources/messages.yml Add general, no-permission, and reload messages
src/main/resources/config.yml Add updater settings
src/main/java/gg/nextforge/updater/CoreAutoUpdater.java Support dev releases and async download
src/main/java/gg/nextforge/text/TextManager.java New Audience-based parse and placeholder replacement
src/main/java/gg/nextforge/command/builtin/NextCoreCommand.java Implement /nextcore commands and help output
src/main/java/gg/nextforge/NextCorePlugin.java Wire in config, messages, scheduler, and commands
.github/workflows/release.yml Extract version dynamically, support prereleases
.github/workflows/qodana_code_quality.yml Add Qodana CI job
Comments suppressed due to low confidence (1)

.github/workflows/release.yml:11

  • [nitpick] The firstName input parameter is defined but never used in the workflow. Removing it will simplify the dispatch interface.
      firstName:


if (resolver != null) {
try {
String replacement = resolver.apply(null);
Copy link

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing null into the placeholder resolver ignores the provided Audience. You should pass the actual player instance (cast from Audience) instead of null.

Suggested change
String replacement = resolver.apply(null);
String replacement = resolver.apply(player instanceof Player ? (Player) player : null);

Copilot uses AI. Check for mistakes.
Comment on lines +19 to +21
ConfigFile configFile;
ConfigFile messagesFile;
ScheduledTask updateCheckTask;
Copy link

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Fields configFile, messagesFile, and updateCheckTask are package-private. Consider marking them private to enforce encapsulation and prevent accidental external modification.

Suggested change
ConfigFile configFile;
ConfigFile messagesFile;
ScheduledTask updateCheckTask;
private ConfigFile configFile;
private ConfigFile messagesFile;
private ScheduledTask updateCheckTask;

Copilot uses AI. Check for mistakes.
@NextForge-Development NextForge-Development deleted a comment from Copilot AI Jul 9, 2025
@NextForge-Development NextForge-Development deleted a comment from Copilot AI Jul 9, 2025
@mzcydev mzcydev merged commit ca12ef1 into dev Jul 9, 2025
0 of 3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants