Scroll instruments list with Y+D-pad #139
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by NitrousTracker#118 (although it doesn't do anything nearly as drastic as reworking tobkit to support focusing). The Y button is currently unused, and it's common for trackers to include shortcuts to easily scroll up and down the instrument list, without use of the computer mouse. Y+Up and Y+Down move up and down, respectively (no wraparound). Holding B during this operation moves in units of four rows instead of one, in the same manner as the pattern editor. Y+R+Up jumps to the top of the instrument list. Y+R+Down, however, does not jump to the bottom, as it is ambiguous as to whether it should jump to the maximum scrollable instrument slot (always 0x7f, or 80), or the last populated instrument. (redid previous pr as I messed something up and it got cluttered)
asiekierka
force-pushed
the
new
branch
2 times, most recently
from
f91c478 to
9d273ae
Compare
Author
|
converting to draft as the consensus on button stuff seemed undecided |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #118 (although it doesn't do anything nearly as drastic as reworking tobkit to support focusing).
The Y button is currently unused, and it's common for trackers to include shortcuts to easily scroll up and down the instrument list, without use of the computer mouse.
Y+Up and Y+Down move up and down, respectively (no wraparound).
Holding B during this operation moves in units of four rows instead of one, in the same manner as the pattern editor.
Y+R+Up jumps to the top of the instrument list. Y+R+Down, however, does not jump to the bottom, as it is ambiguous as to whether it should jump to the maximum scrollable instrument slot (always 0x7f, or 80), or the last populated instrument.
(redid previous pr as I messed something up and it got cluttered)